Impl. more component-wise built-ins in const. eval. #4879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
added
naga
ErichDonGubler
force-pushed
the
builtins-const-eval-1
branch
2 times, most recently
from
435ed16
to
596bef9
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-1
branch
2 times, most recently
from
333cb71
to
c7b07d9
Compare
ErichDonGubler
commented
Dec 22, 2023
ErichDonGubler
force-pushed
the
builtins-const-eval-1
branch
2 times, most recently
from
342c881
to
7b7a115
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
force-pushed
the
builtins-const-eval-1
branch
from
7b7a115
to
7356181
Compare
ErichDonGubler
commented
Dec 22, 2023
73 tasks
ErichDonGubler
force-pushed
the
builtins-const-eval-1
branch
from
0b06e78
to
e6e0dcf
Compare
teoxoy
requested changes
Jan 3, 2024
ErichDonGubler
force-pushed
the
builtins-const-eval-1
branch
3 times, most recently
from
691f37a
to
99c54f4
Compare
jimblandy
reviewed
Jan 8, 2024
ErichDonGubler
force-pushed
the
builtins-const-eval-1
branch
from
99c54f4
to
b860233
Compare
ErichDonGubler
force-pushed
the
builtins-const-eval-1
branch
3 times, most recently
from
53bfd62
to
528bfca
Compare
ErichDonGubler
dismissed
jimblandy’s stale review
Spoke on call, agreed to merge and iterate.
ErichDonGubler
force-pushed
the
builtins-const-eval-1
branch
from
d5cb4bd
to
af20cb3
Compare
ErichDonGubler
commented
Jan 18, 2024
|
🎉 |
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Resolves many numeric built-ins listed under #4507, and sets the groundwork for many more.
Description
Adds support for evaluating the following built-in functions:
abssaturatecoscoshsinsinhtantanhacosacoshasinasinhatanatanhroundstepsqrtTesting
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.